/charm

Rename series to supported-series #155

Merged
merged 1 commit into from Sep 28, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@wallyworld @rogpeppe @marcoceppi @johnsca @chuckbutler
@wallyworld
Owner

wallyworld commented Sep 28, 2015

Rename the Series attribute in Meta to SupportedSeries.
The Series attribute is not used.
@rogpeppe
Owner

rogpeppe commented Sep 28, 2015

LGTM thanks

wallyworld added a commit that referenced this pull request Sep 28, 2015

@wallyworld
Merge pull request #155 from wallyworld/use-supported-series 
Rename series to supported-series
3c02d70

@wallyworld wallyworld merged commit 3c02d70 into juju:v6-unstable Sep 28, 2015

@marcoceppi
Owner

marcoceppi commented Sep 28, 2015

Is there a reason for the remane? supported-series is so much longer when series: [] achieves the same effect.
@johnsca
Member

johnsca commented Sep 28, 2015

I agree. "series" seems perfectly reasonable to me and I don't understand why we would change this.
@chuckbutler

chuckbutler commented Sep 28, 2015

series: [] seems succinct enough. I'm not following the logic for the rename either.

@marcoceppi marcoceppi referenced this pull request Sep 28, 2015

Open

supported-series metadata key name provides a poor user experience #156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment