/charm

Added support for extra-bindings within BundleData #192

Merged
merged 1 commit into from Mar 2, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@dimitern @frankban @jujubot
@dimitern

dimitern commented Mar 1, 2016

Following up on #191, this PR allows extra-bindings
to work when deploying bundles containing charm with extra-bindings in their metadata.

@dimitern dimitern referenced this pull request in juju/juju Mar 2, 2016

Merged

Added support for extra-bindings in charm metadata incl. for bundles #4598

@frankban
Member

frankban commented Mar 2, 2016

👍 thank you!
@dimitern

dimitern commented Mar 2, 2016

Thanks! $$merge$$
@jujubot
Contributor

jujubot commented Mar 2, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-charm

jujubot added a commit that referenced this pull request Mar 2, 2016

@jujubot
Merge pull request #192 from dimitern/v6-unstable-extra-bindings-bund… 
…ledata

Added support for extra-bindings within BundleData

Following up on #191, this PR allows extra-bindings
to work when deploying bundles containing charm with extra-bindings in their metadata.
9a74909

@jujubot jujubot merged commit 9a74909 into juju:v6-unstable Mar 2, 2016

@dimitern dimitern deleted the dimitern:v6-unstable-extra-bindings-bundledata branch Mar 2, 2016

dimitern pushed a commit to dimitern/juju that referenced this pull request Mar 2, 2016

Updated dependencies.tsv after PR juju/charm#192 landed
2224ed6

jujubot added a commit to juju/juju that referenced this pull request Mar 2, 2016

@jujubot
Merge pull request #4598 from dimitern/maas-spaces2-extra-bindings 
Added support for extra-bindings in charm metadata incl. for bundles

CLI deploy command modified to accept both relation names and entries from
the extra-bindings map of the charm metadata, if they exist.

Depends on juju/charm#192 landing first.

(Review request: http://reviews.vapour.ws/r/4038/)
650e86e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment