Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Merging features necessary for Juju Min Version #194
Conversation
natefinch
and others
added some commits
Oct 26, 2015
wallyworld
reviewed
Mar 8, 2016
| + c.Check(err, gc.ErrorMatches, `invalid version "invalid-version"`) | ||
| +} | ||
| + | ||
| +// TestInvalidSeries ensures that invalid series values cause a parse error |
wallyworld
reviewed
Mar 8, 2016
| +func (s *MetaSuite) TestInvalidMinJujuVersion(c *gc.C) { | ||
| + _, err := charm.ReadMeta(strings.NewReader(dummyMetadata + "\nmin-juju-version: invalid-version")) | ||
| + | ||
| + c.Check(err, gc.ErrorMatches, `invalid version "invalid-version"`) |
wallyworld
Mar 8, 2016
Owner
can the error message be 'invalid min-juju-version "foo"' so the user knows what attribute is wrong
|
LGTM with a couple of trivial fixes |
|
If we stick with having the attr as a version.Number we'd add schema support for it. May a todo would be good |
|
LGTM |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-charm |
added a commit
that referenced
this pull request
Mar 8, 2016
jujubot
merged commit c3eac73
into
juju:v6-unstable
Mar 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
kat-co commentedMar 8, 2016
This introduces a dependency on github.com/juju/version.