/charm

support yaml.v2 marshaling for Meta #195

Merged
merged 1 commit into from Mar 9, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@rogpeppe @mhilton @dimitern @frankban @jujubot
@rogpeppe
Owner

rogpeppe commented Mar 8, 2016

The YAML package changed its method names. We can support both versions.
@mhilton
Member

mhilton commented Mar 8, 2016

👍
@dimitern

dimitern commented Mar 9, 2016

Why on earth should we use 2 versions of the same package though is a mystery to me :/
@frankban
Member

frankban commented Mar 9, 2016

👍
@dimitern

dimitern commented Mar 9, 2016

👍
@rogpeppe
Owner

rogpeppe commented Mar 9, 2016

We can support both v1 and v2 - we have clients that use both, and it seems
reasonable to support both for the time being.
@rogpeppe
Owner

rogpeppe commented Mar 9, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Mar 9, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-charm

jujubot added a commit that referenced this pull request Mar 9, 2016

@jujubot
Merge pull request #195 from rogpeppe/039-support-yaml.v2 
support yaml.v2 marshaling for Meta

The YAML package changed its method names. We can support both versions.
4ad4f4b

@jujubot jujubot merged commit 4ad4f4b into juju:v6-unstable Mar 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment