Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
add BundleData.UnmarshaledWithServices method #212
Conversation
|
|
natefinch
reviewed
Jun 9, 2016
| @@ -373,6 +373,26 @@ func (u *URL) UnmarshalJSON(b []byte) error { | ||
| return nil | ||
| } | ||
| +// MarshalTest implements encoding.TextMarshaler by |
natefinch
reviewed
Jun 9, 2016
| + return []byte(u.String()), nil | ||
| +} | ||
| + | ||
| +// Unmarshal implements encoding.TestUnmarshaler by |
|
LGTM other than those two minor things |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-charm |
jujubot
merged commit 8796be6
into
juju:v6-unstable
Jun 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
rogpeppe commentedJun 9, 2016
•
Edited 1 time
-
rogpeppe
Jun 9, 2016
This allows code to know when a bundle has been
unmarshaled from the old format.
Also test marshaling/unmarshaling more fully for
all supported codecs, and remove the obsolete
Meta.Version and Meta.Format fields that have been
deprecated for a long time. We still accept those
fields for backward compatibility but they're ignored.