/charm

Remove charm.URL.Channel #220

Merged
merged 1 commit into from Sep 16, 2016

Conversation

Reviewers

@frankban frankban

@natefinch natefinch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@babbageclunk @jujubot @frankban @natefinch
@babbageclunk
Member

babbageclunk commented Sep 15, 2016

It's no longer part of the charm URL, it's handled at a higher level.

(Preliminary task for fixing http://pad.lv/1584193.)
@babbageclunk
Remove charm.URL.Channel 
It's no longer part of the charm URL, it's handled at a higher level.
dffd031
@natefinch

natefinch approved these changes Sep 15, 2016
View changes

I don't know about the bigger picture, but this particular change LGTM.

@frankban

frankban approved these changes Sep 15, 2016
View changes

Thanks for getting rid of channels in URLs!

@babbageclunk
Member

babbageclunk commented Sep 16, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Sep 16, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-charm

@jujubot jujubot merged commit e62786f into juju:v6-unstable Sep 16, 2016

@babbageclunk babbageclunk deleted the babbageclunk:remove-channel branch Sep 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment