Fixed outdated import

[bogdanteleaga]

This PR changes the import of gocheck from launchpad to github.

[jameinel]

LGTM

[jameinel]

This can't be merged until github.com/juju/testing is updated, because it uses a checkers.DeepEquals but the signature is different:
gocheck.Checker does not implement check.Checker (wrong type for Info method)
have Info() *gocheck.CheckerInfo
want Info() *check.CheckerInfo

[jameinel]

So, I have to revise my position. I do think that for Go code that has committed to "stable versioned APIs" (like gopkg.in/juju/check.v3) that means that if you could run "go test" before and it passed, and you run "go test" after an update and it would fail, that means that we are breaking our API (we are breaking the testing interface for this package).

As such, I think this needs to be creating a new "v4" branch, and we should be updating all things that depend on it to start importing "gopkg.in/juju/check.v4" instead.

I'll bring it up on the list, but we'll want to sort that out before we go any further.

[jameinel]

I ended up also needing to rename all the import locations internally (since it will be at a new path on disk, etc).
Ends up being a fair amount of work, but I think I have it working (we'll then also need to change github to change what the default branch is.)

[mattyw]

Can this be closed?