Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add support for parsing more charm storage metadata #88
Conversation
axw
reviewed
Mar 3, 2015
| + // such as tmpfs or ephemeral instance disks. | ||
| + // | ||
| + // Properties has no default, and is optional. | ||
| + Properties []string `bson:properties,omitempty` |
axw
Mar 3, 2015
Member
Given that we won't be honouring properties yet, and it's not clear in the spec whether properties are requirements or hints (I opened a question, never got answered), I'd really rather if this got left out for now.
wallyworld
Mar 3, 2015
Owner
As discussed live, the properties are used as hints and jam is ok with implementing these now.
axw
reviewed
Mar 3, 2015
| + yaml: " type: block\n minimum-size: 10Q", | ||
| + err: `metadata: invalid multiplier suffix "Q", expected one of MGTPEZY`, | ||
| + }, { | ||
| + desc: "properties must contain valid valies must have valid suffix", |
|
LGTM, but I think it's premature to add |
added a commit
that referenced
this pull request
Mar 3, 2015
wallyworld
merged commit c9dacb8
into
juju:v4
Mar 3, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
wallyworld commentedMar 3, 2015
minimum-size and properties are now supported in charm storage metadata