Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove size from ResourceData #108

Merged
merged 1 commit into from Nov 17, 2016
Merged

Remove size from ResourceData #108

merged 1 commit into from Nov 17, 2016

Conversation

natefinch
Copy link
Contributor

We're not guaranteed to get a content-length from our get request, so we can't
guarantee we'll have anything to put in size.

This is half of a fix for https://bugs.launchpad.net/juju/+bug/1628786

We're not guaranteed to get a content-length from our get request, so we can't
guarantee we'll have anything to put in size.
@jujugui
Copy link
Contributor

jujugui commented Nov 17, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/charmrepo/292/
Test PASSed.

Copy link
Member

@wallyworld wallyworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to understand why content length is not always set. Can't we use it if set and ignore it if not? Why is it set sometimes and not others?

@mitechie
Copy link
Contributor

+1 to @wallyworld as far as description of the problem and a link to the bug report on the charmstore that should be tracked/related to this issue.

@natefinch
Copy link
Contributor Author

You can't trust content-length, evidently. It gets removed often in the case of gzipped responses. Since we also have the hash, which if it matches must mean the size matches as well.

@natefinch
Copy link
Contributor Author

$$merge$$

@natefinch
Copy link
Contributor Author

:shipit:

@jujugui
Copy link
Contributor

jujugui commented Nov 17, 2016

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/charmrepo-merge

@jujugui jujugui merged commit e79aa29 into juju:v2-unstable Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants