Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Remove size from ResourceData #108
Conversation
|
Test PASSed. |
wallyworld
approved these changes
Nov 17, 2016
It would be good to understand why content length is not always set. Can't we use it if set and ignore it if not? Why is it set sometimes and not others?
|
+1 to @wallyworld as far as description of the problem and a link to the bug report on the charmstore that should be tracked/related to this issue. |
|
You can't trust content-length, evidently. It gets removed often in the case of gzipped responses. Since we also have the hash, which if it matches must mean the size matches as well. |
|
$$merge$$ |
|
|
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/charmrepo-merge |
natefinch commentedNov 17, 2016
We're not guaranteed to get a content-length from our get request, so we can't
guarantee we'll have anything to put in size.
This is half of a fix for https://bugs.launchpad.net/juju/+bug/1628786