Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Use newer charm.v6 repo and update tests #30
Conversation
|
Test FAILed. |
rogpeppe
reviewed
Sep 28, 2015
| + jujutesting "github.com/juju/testing" | ||
| +) | ||
| + | ||
| +var noTestMongoJs *bool = flag.Bool("notest-mongojs", false, "Disable MongoDB tests that require JavaScript") |
rogpeppe
Sep 28, 2015
Owner
What's this doing in a non-test file? It seems entirely test related to me and AFAICS there's no non-test code that uses it.
rogpeppe
reviewed
Sep 28, 2015
| +var noTestMongoJs *bool = flag.Bool("notest-mongojs", false, "Disable MongoDB tests that require JavaScript") | ||
| + | ||
| +func init() { | ||
| + if os.Getenv("JUJU_NOTEST_MONGOJS") == "1" || jujutesting.MgoServer.WithoutV8 { |
rogpeppe
Sep 28, 2015
Owner
I think let's just use either the env var or the flag. Probably the env var 'cos that means you can go test ./... .
|
Test FAILed. |
|
Test PASSed. |
wallyworld commentedSep 28, 2015
Update to use newer charm.v6 repo.
Fix a failing test.
Allow tests which use javascript in mongo to be skipped.