/charmrepo

Bundle notfound error #36

Merged
merged 3 commits into from Nov 4, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@wallyworld @jujugui @axw
@wallyworld
Owner

wallyworld commented Nov 4, 2015

Add a new BundleNotFound error to match what is done for charms.
Also, when loading a charm or bundle from a path, check that a supplied path exists before testing if it is relative or not.
@jujugui
Member

jujugui commented Nov 4, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/charmrepo/84/
Test PASSed.
params.go
func CharmNotFound(url string) error {
return &NotFoundError{
msg: "charm not found: " + url,
}
}
+// BundleNotFound represents an error indicating that the
@axw

axw Nov 4, 2015

Member

s/represents/returns/

@axw
Member

axw commented Nov 4, 2015

LGTM with a couple of trivial doc changes.
@jujugui
Member

jujugui commented Nov 4, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/charmrepo/85/
Test PASSed.
@wallyworld
Owner

wallyworld commented Nov 4, 2015

:shipit:
@jujugui
Member

jujugui commented Nov 4, 2015

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/charmrepo-merge

jujugui added a commit that referenced this pull request Nov 4, 2015

@jujugui
Merge pull request #36 from wallyworld/bundle-notfound-error 
Bundle notfound error

Add a new BundleNotFound error to match what is done for charms.
Also, when loading  a charm or bundle from a path, check that a supplied path exists before testing if it is relative or not.
02109f9

@jujugui jujugui merged commit 02109f9 into juju:v2-unstable Nov 4, 2015
1 check passed

1 check passed

default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment