Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query store for supported series of charm #55

Merged
merged 2 commits into from Nov 26, 2015

Conversation

wallyworld
Copy link
Member

Add support for querying the supported-series for a charm when resolving. The requires the new charm store.

@jujugui
Copy link
Contributor

jujugui commented Nov 24, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/charmrepo/132/
Test PASSed.

@@ -506,33 +506,41 @@ func (s *charmStoreRepoSuite) TestResolve(c *gc.C) {

// Define the tests to be run.
tests := []struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have at least one test that tests the results for a multi-series charm, please?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@rogpeppe
Copy link
Contributor

LGTM with another test or two. Thanks!

@jujugui
Copy link
Contributor

jujugui commented Nov 26, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/charmrepo/134/
Test PASSed.

@wallyworld
Copy link
Member Author

:shipit:

@jujugui
Copy link
Contributor

jujugui commented Nov 26, 2015

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/charmrepo-merge

jujugui added a commit that referenced this pull request Nov 26, 2015
Query store for supported series of charm

Add support for querying the supported-series for a charm when resolving. The requires the new charm store.
@jujugui jujugui merged commit 0dccc5f into juju:v2-unstable Nov 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants