Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
csclient: use bakery.v1 #7
Conversation
|
|
mhilton
reviewed
May 15, 2015
| @@ -21,6 +21,7 @@ gopkg.in/juju/charm.v5 git 39463053128b672308c459958d00f260b58ce79e 2015-05-14T1 | ||
| gopkg.in/juju/charm.v6-unstable git 69e524672748337e749acb16dbeefe3e80c946c0 2015-05-05T17:09:44Z | ||
| gopkg.in/juju/charmstore.v4 git 3a87b423c3eeb105b82bba2f87d593d1b5763845 2015-05-14T14:17:49Z | ||
| gopkg.in/macaroon-bakery.v0 git 9593b80b01ba04b519769d045dffd6abd827d2fd 2015-04-10T07:46:55Z |
mhilton
May 15, 2015
Member
I'm a little worried your depending on two versions of the same library, that's not right surely.
rogpeppe
May 15, 2015
Owner
As I mention in the PR description, we can't change that right now, but will be able to once this update is incorporated into charmstore.
mhilton
reviewed
May 15, 2015
| @@ -37,6 +37,7 @@ var ServerURL = "https://api.jujucharms.com/charmstore" | ||
| // Client represents the client side of a charm store. | ||
| type Client struct { |
mhilton
May 15, 2015
Member
I'm not sure why we feel we have to hide the parameters here, I would have thought that something more like http.Client where you can just set the parts as necessary would be better. Don't change anything just a passing thought.
rogpeppe
May 15, 2015
Owner
Yeah, it could definitely have been done that way, although it makes it a little more fragile. I went with keeping the existing API.
|
|
added a commit
that referenced
this pull request
May 15, 2015
rogpeppe commentedMay 14, 2015
Since the charm store still uses bakery.v0, we need to use both in csclient tests;
we move to using bakery.v1 only when we update it.