Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Prepare to drop some CharmStore methods. #78
Conversation
ericsnowcurrently
added some commits
Feb 25, 2016
|
Test PASSed. |
|
Per PR #75, the directive relative to CharmStore is pretty clear. |
|
LGTM |
|
|
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/charmrepo-merge |
jujugui
merged commit 76b4dac
into
juju:v2-unstable
Mar 29, 2016
1 check passed
default
Merged build finished.
Details
ericsnowcurrently
deleted the
ericsnowcurrently:move-methods-to-client
branch
Mar 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ericsnowcurrently commentedMar 19, 2016
The CharmStore type has several exported methods that are not part of Interface. If the goal is to have CharmStore be a strictly conforming implementation then these methods do not belong. With the addition of CharmStore.Client() we can remove all but one of the methods. They are either unnecessary or may be implemented as needed in juju core. The one remaining method is Latest(). This patch moves it to csclient.Client.
Once core has been updated appropriately, the entire charmstore_going_away.go file may be removed.