change GetResource to return the full resource metadata w/ bytes #80

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

natefinch commented Mar 22, 2016

We changed to use a multipart body to return the data, so we don't have to use a bunch of ugly headers.

Also did a little cleanup of some spots where we were unnecessarily reading the full body into memory.

change GetResource to return the full resource metadata along with th…
…e bytes.

We changed to use a multipart body to return the data, so we don't have to use a bunch of ugly headers.

Also did a little cleanup of some spots where we were unecessarily reading the full body into memory.
Member

jujugui commented Mar 22, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/charmrepo/220/
Test PASSed.

Contributor

natefinch commented Mar 23, 2016

In an external discussion, we have decided to drop the multi-part body approach and instead simply do two requests against the charmstore, one for the bytes and one for the metadata.

@natefinch natefinch closed this Mar 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment