add macaroon support to csclient.Params #82
Conversation
| // A non-nil error here will get caught at request time when we try | ||
| // to parse the URL, and without a valid URL, the macaroons don't matter | ||
| // anyway. | ||
| if err == nil { |
There was a problem hiding this comment.
I know this is bad. In discussion with Roger, it was decided that it was better to avoid a breaking change at this time (by forcing New to return an error), so we're just swallowing it for now, though as stated in the comment, the failure to parse would mean that requests will inevitably fail with the same parse failure, at which point, the use of macaroons is moot.
|
Test PASSed. |
|
Test PASSed. |
|
LGTM |
|
|
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/charmrepo-merge |
No description provided.