/charmrepo

Add CharmStore.ResolveWithChannel(). #84

Merged
merged 6 commits into from Apr 8, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ericsnowcurrently @jujugui @kat-co
@ericsnowcurrently
Contributor

ericsnowcurrently commented Apr 6, 2016

We need a reliable way to determine which channel will be used for a charm URL. The natural place to get that info is when resolving that charm URL. This patch adds a ResolveWithChannel() method to the CharmStore type.
@jujugui
Member

jujugui commented Apr 6, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/charmrepo/230/
Test PASSed.
@kat-co
Contributor

kat-co commented Apr 8, 2016

LGTM
@ericsnowcurrently
Contributor

ericsnowcurrently commented Apr 8, 2016

:shipit:
@jujugui
Member

jujugui commented Apr 8, 2016

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/charmrepo-merge

@jujugui jujugui merged commit 9a33b60 into juju:v2-unstable Apr 8, 2016
1 check passed

1 check passed

default Merged build finished.
Details

@ericsnowcurrently ericsnowcurrently deleted the ericsnowcurrently:best-channel branch Apr 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment