Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
plugins list in help output #2
Conversation
|
LGTM |
mhilton
closed this
Mar 18, 2016
mhilton
reopened this
Mar 18, 2016
|
Test FAILed. |
mhilton
reviewed
Mar 18, 2016
| - chcmd.Register(&showCommand{}) | ||
| - chcmd.Register(&termsCommand{}) | ||
| - chcmd.Register(&whoamiCommand{}) | ||
| + commands := []cmd.Command{ |
mhilton
Mar 18, 2016
Member
I wonder if this might be a little easier if it was a map? It might save you a few loops?
mhilton
reviewed
Mar 18, 2016
| -// Since this is never actually called, we can happily return nil. | ||
| -func (*pluginCommand) Info() *cmd.Info { | ||
| - return nil | ||
| +// Info returns informationa bout the Command. |
mhilton
reviewed
Mar 18, 2016
| + } | ||
| + name := pc.name | ||
| + if name == "" { | ||
| + name = pc.name |
mhilton
reviewed
Mar 18, 2016
| @@ -100,10 +116,16 @@ func pluginHelpTopic() string { | ||
| return output.String() | ||
| } | ||
| +// getPluginDescriptionsResults holds memoized results for getPluginDescriptions. | ||
| +var getPluginDescriptionsResults []pluginDescription |
mhilton
Mar 18, 2016
Member
perhaps call this pluginDescriptionResults getPluginDescriptionResults made me think it was a function.
|
|
|
Test PASSed. |
|
Test PASSed. |
|
Test PASSed. |
|
|
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/charmstore-client-merge |
added a commit
that referenced
this pull request
Mar 21, 2016
jrwren commentedMar 17, 2016
Also fixed
plugin -handhelp pluginoutput.