Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
cmd/charm/charmcmd: simplify plugin processing #66
Conversation
|
Test FAILed. |
|
|
|
Test PASSed. |
urosj
reviewed
May 26, 2016
| - } | ||
| - if err != cmd.ErrSilent { | ||
| - fmt.Fprintf(ctx.Stderr, "error: %v\n", err) | ||
| +// New returns a command that can execute juju-charm |
|
Code @fabricematrat could you do QA and check how this works with charm-tools before it lands? |
|
Test FAILed. |
|
|
|
Test PASSed. |
|
|
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/charmstore-client-merge |
rogpeppe commentedMay 25, 2016
With the help of a small addition to the juju/cmd API
we can avoid the need to register plugin commands in
advance, thus speeding up the charm command in the
common case. As a bonus this means we don't need
any of the custom (mostly duplicated) code to layer
on top of cmd.SuperCommand, so we can delete all that.