Remove uses of charm.URL.Channel #681

Merged
merged 3 commits into from Sep 16, 2016

Conversation

Projects
None yet
3 participants
Member

babbageclunk commented Sep 16, 2016

This has been removed from charm.URL in the process of implementing http://pad.lv/1584193.

The only uses were checking that the url had no channel or removing the channel from a url.

Updated charm.v6-unstable dependency. This is arguably unnecessary, but it's safer - otherwise someone could pass in a charm url with a channel and this code would no longer strip it out.

babbageclunk added some commits Sep 15, 2016

Remove uses of charm.URL.Channel
This has been removed from charm.URL in the process of implementing
http://pad.lv/1584193.
Update the charm.v6-unstable dependency
This is arguably unnecessary, but it's safer - otherwise someone could
pass in a charm url with a channel and this code would no longer strip
it out.
Member

jujugui commented Sep 16, 2016

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/charmstore/1902/
Test FAILed.

Member

jujugui commented Sep 16, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/charmstore/1903/
Test PASSed.

Looks good, thanks for this!

Member

babbageclunk commented Sep 16, 2016

:shipit:

Member

jujugui commented Sep 16, 2016

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/charmstore-merge

@jujugui jujugui merged commit fd1eef3 into juju:v5-unstable Sep 16, 2016

1 check passed

default Merged build finished.
Details

@babbageclunk babbageclunk deleted the babbageclunk:remove-url-channel branch Sep 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment