Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Remove uses of charm.URL.Channel #681
Conversation
babbageclunk
added some commits
Sep 15, 2016
|
Test FAILed. |
|
Test PASSed. |
|
|
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/charmstore-merge |
jujugui
merged commit fd1eef3
into
juju:v5-unstable
Sep 16, 2016
1 check passed
default
Merged build finished.
Details
babbageclunk
deleted the
babbageclunk:remove-url-channel
branch
Sep 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
babbageclunk commentedSep 16, 2016
This has been removed from charm.URL in the process of implementing http://pad.lv/1584193.
The only uses were checking that the url had no channel or removing the channel from a url.
Updated charm.v6-unstable dependency. This is arguably unnecessary, but it's safer - otherwise someone could pass in a charm url with a channel and this code would no longer strip it out.