Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add RemoteApplication and -Endpoint to description #1
Conversation
| + // TODO(babbageclunk): implement importing remote applications | ||
| + if val, ok := sourceMap["remote-applications"]; ok { | ||
| + if items, ok := val.([]interface{}); ok && len(items) != 0 { | ||
| + return nil, errors.New("importing remote applications is not supported yet") |
babbageclunk
Feb 23, 2017
Member
I can see an argument for filling the deserialization code in now and preventing importing of remote applications in migration_import instead, but this was easier (and it's not any harder to do it later). I'm alright with doing it if others feel strongly.
howbazaar
requested changes
Feb 24, 2017
Unfortunately a lot more is needed here.
remote-applications are not part of the version 1 or models. We need to have a version 2 model that includes remote-applications.
Also, the deserialisation should be done at the same time. Importing in the state package can fail, but the model serialization should be complete.
babbageclunk
added some commits
Feb 28, 2017
|
Now with deserialisation of remote applications and endpoints and version 2 of the model format. |
|
$$merge$$ |
howbazaar
merged commit 6686f41
into
juju:master
Feb 28, 2017
babbageclunk
deleted the
babbageclunk:remote-apps
branch
Feb 28, 2017
babbageclunk
referenced this pull request
in juju/juju
Feb 28, 2017
Merged
Include remote applications in model dump #7049
added a commit
to juju/juju
that referenced
this pull request
Feb 28, 2017
babbageclunk commentedFeb 23, 2017
This will allow dump-model to work on models with cross-model relations.
For now remote applications will be serializable but not importable. We
don't want to accidentally allow a migration to appear to succeed while
not migrating remote applications from the source model, and migrating
remote applications will require much more thought.
Handle remote applications in model.Validate. Since there are no units
in the local model for a remote application, we can't check that the
settings for the endpoints and units match up.