/description

Add SLA owner. #11

Merged
merged 1 commit into from Apr 6, 2017

Conversation

Reviewers

@mjs mjs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cmars @mjs
@cmars
Owner

cmars commented Apr 5, 2017

Supporting juju/juju#7202.

@cmars cmars referenced this pull request in juju/juju Apr 5, 2017

Merged

Show model SLA owner #7202

model.go
@@ -1127,6 +1128,7 @@ func modelV2Fields() (schema.Fields, schema.Defaults) {
fields["sla"] = schema.FieldMap(
schema.Fields{
"level": schema.String(),
+ "owner": schema.String(),
@mjs

mjs Apr 6, 2017

Doesn't this mean that you need to introduce a new version of the model struct? (v3 by the looks)

@cmars

cmars Apr 6, 2017

Owner

I can add a v3 if its required, but SLAs are new in Juju 2.2 and this feature is not in production yet. Do we really need to support migration of a 2.2 feature across betas?

@mjs

mjs Apr 6, 2017

As per IRC, this should be ok.

@mjs

mjs approved these changes Apr 6, 2017
View changes

@cmars
Owner

cmars commented Apr 6, 2017

$$merge$$

@cmars cmars merged commit 50b9bb7 into juju:master Apr 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment