Dump and load remote application status #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babbageclunk
changed the title
wallyworld
approved these changes
May 8, 2017
model_test.go
Outdated
| @@ -723,6 +723,7 @@ remote-applications: | |||
| spaces: | |||
| spaces: [] | |||
| version: 1 | |||
| status: null | |||
There was a problem hiding this comment.
let's set a status - status would not be empty, it would start out as something like "unknown" like we do for units
This is now required by extra safety-checks in migration.
babbageclunk
force-pushed
the
remote-application-status
branch
from
2589763
to
c0ed514
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now required by extra safety-checks in migration.