/description

Make storage "owner" and "attachments" optional #2

Merged
merged 1 commit into from Mar 2, 2017

Conversation

Reviewers

@howbazaar howbazaar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@axw @howbazaar
@axw
Member

axw commented Mar 2, 2017

Bump the schema version of storages to 2, and
make the owner and attachments fields of storage
optional. This is to support persistent storage
changes.
@axw
Make storage "owner" and "attachments" optional 
Bump the schema version of storages to 2, and
make the owner and attachments fields of storage
optional. This is to support persistent storage
changes.
This commit was signed with a verified signature.
@axw axw Andrew Wilkins
GPG key ID: 55314F7628952B05 Learn about signing commits
24978ca
storage_test.go
c.Assert(err, jc.ErrorIsNil)
- c.Assert(source, jc.DeepEquals, testStorageMap())
+ c.Assert(string(out), jc.YAMLEquals, testStorage)
@howbazaar

howbazaar Mar 2, 2017

Owner

Oh... interesting. When did YAMLEquals get made?

@howbazaar

howbazaar Mar 2, 2017

Owner

Hmm... seems that YAMLEquals should support []byte input.

@axw

axw Mar 2, 2017

Member

Frank wrote it in 2014 ;)
Agreed, I'll update it next time I'm in the area.

@axw
Member

axw commented Mar 2, 2017

$$merge$$

@howbazaar howbazaar merged commit bbbc7aa into juju:master Mar 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment