Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
WIP: Terms documentation #1048
Conversation
AdamIsrael
added some commits
Apr 28, 2016
AdamIsrael
referenced this pull request
Apr 28, 2016
Closed
missing docs for implementing Resources and Terms #935
alesstimec
reviewed
Apr 29, 2016
| +usual. If not, the user will be prompted to run the `juju agree` command in | ||
| +order to deploy. | ||
| + | ||
| +You can view which charm terms you've accepted by installing |
alesstimec
reviewed
Apr 29, 2016
| +order to deploy. | ||
| + | ||
| +You can view which charm terms you've accepted by installing | ||
| +[charm-tools](./tools-charm-tools.html) and running `charm terms`. |
|
A few comments from me.. |
mattyw
reviewed
Apr 29, 2016
| + | ||
| +# Writing charms that use terms | ||
| + | ||
| +Many applications require the acceptance of Terms in order to be installed. |
mattyw
reviewed
Apr 29, 2016
| +## Creating terms | ||
| + | ||
| +At the moment, terms can only be created by charm store administrators. | ||
| +Charm developers should send an email to juju@lists.ubuntu.com with: |
mattyw
Apr 29, 2016
Member
I'd recommend giving them a subject to use, that way we can add filters to catch these messages, also maybe we should ask them to fill out a form so they don't need to send their terms to the whole list
AdamIsrael
May 4, 2016
Contributor
I completely agree. Since your team (I think?) will be the one responsible for creating terms, how do you want to go about it? A Google spreadsheet/form seems handy in this case, but I don't know if it can be setup to send notifications when new forms are submitted.
I still favor the idea of using a Github repo, though, where the issues template can be customized for the information need. Notifications work, issues can be assigned and progress tracked.
cmars
May 4, 2016
Owner
Let's use a Google Form for this purpose: https://goo.gl/forms/7cGy0Oztmd
It collects all the form submissions to a spreadsheet, and I've enabled email notifications for it.
mattyw
reviewed
Apr 29, 2016
| +description: | | ||
| + This is a longer description which | ||
| + potentially contains multiple lines. | ||
| +terms: ["lorem-ipsum"] |
alesstimec
May 4, 2016
Member
no.. without revision it will require agreement to the latest revision of that term
mattyw
reviewed
Apr 29, 2016
| + | ||
| +The `terms` key can include multiple terms to be required. It can also require | ||
| +specific versions of a term, i.e., `lorem-ipsum/2` would reference the second | ||
| +version of the `lorem-ipsum` term. Omitting the version will require the latest |
cmars
May 10, 2016
Owner
@AdamIsrael We've just released the fix for this to production. cs:~cmars/trusty/canonical-terms-example has a metadata.yaml requiring agreement to latest terms.
AdamIsrael
added some commits
May 4, 2016
|
when you are happy with the peer-review on any PR, if you just make a comment @juju/docs we can scan it over and merge. |
alesstimec
reviewed
May 11, 2016
| + | ||
| +## Upgrading terms | ||
| + | ||
| +Deployed charms will run under the terms they were installed with. If the terms |
alesstimec
May 11, 2016
Member
@cmars i think the wording here is a bit awkward.. charm is not running under terms.. term agreement record is kept in the terms service.. so should the updates charm require newer version of terms or additional term agreement then juju upgrade-charm will ask for additional agreements.. but my english is not good enough to put this in proper sentences.
cmars
May 11, 2016
•
Owner
Let me see what I can come up with... how about:
Services run under an agreement to the terms applicable to the charm when it was deployed. When upgrading a service with
juju upgrade-charm, the user may be prompted to agree to newer revisions of terms already agreed to, or to new terms that have been added to the upgrade charm revision.
|
I would like to see some improvements from @AdamIsrael per comments above in follow-ups, but I think this is a great start and from a technical perspective is good to land as-is. LGTM. |
|
ok, cool. words look fine. Thanks |
evilnick
merged commit a446dc4
into
juju:master
May 20, 2016
|
Thanks for the feedback, @cmars, @mattyw, and @alesstimec. I'll iterate on the docs on soon as time permits. |
AdamIsrael commentedApr 28, 2016
This is the first draft of documentation of the new terms functionality in juju 2.0.