/docs

Insert Bundle Constraints #342

Merged
merged 2 commits into from Apr 9, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@chuckbutler @evilnick @marcoceppi
@chuckbutler
Collaborator

chuckbutler commented Apr 9, 2015

this includes 2 levels of Bundle Constraints:

  • Placement directives
  • Machine Constraints for bare-minimum service requirements
@chuckbutler
Insert Bundle Constraints 
this includes 2 levels of Bundle Constraints:

- Placement directives
- Machine Constraints for bare-minimum service requirements
823761b
@chuckbutler
Collaborator

chuckbutler commented Apr 9, 2015

If approved, will close #341
src/en/charms-bundles.md
+against a charmed service, much like you would when deploying on the command
+line. This is a simple key addition to the service definition, using the proper
+constraint key/value pair as outlined in the [Constraints]() documentation.
+
@evilnick

evilnick Apr 9, 2015

Member

needs actual link in here

@chuckbutler

chuckbutler Apr 9, 2015

Collaborator

doh!

src/en/charms-bundles.md
+
+**Note** the difference between notation when specifying service colocation and
+machine placement directives.
+
@evilnick

evilnick Apr 9, 2015

Member

I am not sure this is necessary if the examples are good and properly labelled. I.e.
For example, to colocate a mysql service with an existing wordpress service:

  • or whatever
@evilnick
Member

evilnick commented Apr 9, 2015

I think one of my comments went astray when github was being weird, but it is okay, I will add it myself :)

evilnick added a commit that referenced this pull request Apr 9, 2015

@evilnick
Merge pull request #342 from chuckbutler/constraints-bundles 
Insert Bundle Constraints
ee461d4

@evilnick evilnick merged commit ee461d4 into juju:1.18 Apr 9, 2015

@marcoceppi
Owner

marcoceppi commented Jun 24, 2015

@evilnick this change needs to be forward ported to ever version of the docs and not just 1.18
@evilnick
Member

evilnick commented Jun 25, 2015

yeah, cool, thanks for reminding me - #341 is still open because I added stuff to the page to explain the examples and someone was supposed to confirm that it was correct... (which is why I hadn't propagated it)
@marcoceppi
Owner

marcoceppi commented Jun 25, 2015

Lgtm

On Wed, Jun 24, 2015, 8:18 PM Nick Veitch notifications@github.com wrote:

yeah, cool, thanks for reminding me - #341
#341 is still open because I added
stuff to the page to explain the examples and someone was supposed to
confirm that it was correct...

—
Reply to this email directly or view it on GitHub
#342 (comment).
@evilnick
Member

evilnick commented Jun 25, 2015

🎆
@chuckbutler
Collaborator

chuckbutler commented Jun 25, 2015

@evilnick no comment :)

@chuckbutler chuckbutler deleted the chuckbutler:constraints-bundles branch Jun 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment