Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert Bundle Constraints #342

Merged
merged 2 commits into from Apr 9, 2015
Merged

Insert Bundle Constraints #342

merged 2 commits into from Apr 9, 2015

Conversation

lazypower
Copy link
Contributor

this includes 2 levels of Bundle Constraints:

  • Placement directives
  • Machine Constraints for bare-minimum service requirements

Insert Bundle Constraints
823761b 
this includes 2 levels of Bundle Constraints:

- Placement directives
- Machine Constraints for bare-minimum service requirements
@lazypower
Copy link
Contributor Author

If approved, will close #341

evilnick
evilnick reviewed Apr 9, 2015
View reviewed changes
src/en/charms-bundles.md
against a charmed service, much like you would when deploying on the command
line. This is a simple key addition to the service definition, using the proper
constraint key/value pair as outlined in the [Constraints]() documentation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs actual link in here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh!

@evilnick
Copy link
Member

evilnick commented Apr 9, 2015

I think one of my comments went astray when github was being weird, but it is okay, I will add it myself :)

evilnick added a commit that referenced this pull request Apr 9, 2015
@evilnick
Merge pull request #342 from chuckbutler/constraints-bundles
ee461d4 
Insert Bundle Constraints
@evilnick evilnick merged commit ee461d4 into juju:1.18 Apr 9, 2015
@marcoceppi
Copy link
Contributor

@evilnick this change needs to be forward ported to ever version of the docs and not just 1.18

@evilnick
Copy link
Member

yeah, cool, thanks for reminding me - #341 is still open because I added stuff to the page to explain the examples and someone was supposed to confirm that it was correct... (which is why I hadn't propagated it)

@marcoceppi
Copy link
Contributor

Lgtm

On Wed, Jun 24, 2015, 8:18 PM Nick Veitch notifications@github.com wrote:

yeah, cool, thanks for reminding me - #341
#341 is still open because I added
stuff to the page to explain the examples and someone was supposed to
confirm that it was correct...

—
Reply to this email directly or view it on GitHub
#342 (comment).

@evilnick
Copy link
Member

🎆

@lazypower
Copy link
Contributor Author

@evilnick no comment :)

@lazypower lazypower deleted the constraints-bundles branch June 28, 2016 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lazypower @evilnick @marcoceppi