Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Developer guide #746
Conversation
mbruzek
and others
added some commits
Nov 2, 2015
|
code formatting a link? |
|
Minor suggestion to link |
|
same with block-type as above |
chuckbutler
and others
added some commits
Nov 17, 2015
axw
commented on src/en/reference-hook-tools.md in 9c8365a
Nov 18, 2015
|
"a charm code"? sounds weird. seemed fine as it was, but if you really think adding "code" in there helps, I think you should drop the "a" |
|
+1 - allows charm code to query, or allows a charm sounds proper. |
|
fixed this. |
axw
commented on src/en/reference-hook-tools.md in 9c8365a
Nov 18, 2015
|
maybe also an example with "storage-get -s data/0 location", which will just print out "/srv/data" |
|
OK |
axw
commented on src/en/developer-storage.md in 9c8365a
Nov 18, 2015
|
I think these limitations belong in charms-storage.md |
|
Moved the section to the "using" document. Thanks for the feedback @axw |
ChrisMacNaughton
commented on src/en/developer-storage.md in 9c8365a
Nov 18, 2015
|
this doesn't quite work for me:
What I think it should be is:
|
|
Updated with your suggestion. Thanks @ChrisMacNaughton ! |
axw
replied
Nov 19, 2015
|
Hold up: storage-get should work without "-s" if you're in a storage-attached or storage-detaching hook. It won't work if you're in a different kind of hook, because there's no implied storage instance for the other hooks. @ChrisMacNaughton what hook were you trying to use it from? |
ChrisMacNaughton
replied
Nov 19, 2015
|
it was in the config-changed I think; the ceph charm, storage branch checks all storage on that hook (https://bazaar.launchpad.net/~axwalk/charms/precise/ceph/trunk/view/head:/hooks/hooks.py#L149), may be worth thinking about how we handle documenting that :) |
axw
replied
Nov 19, 2015
|
@ChrisMacNaughton Agreed, we should be clear about this. If Without any arguments, |
mbruzek
and others
added some commits
Nov 18, 2015
mbruzek
and others
added some commits
Nov 17, 2015
|
Hello I think that there are some unresolved issues which are probably best addressed by raising issues against your branch rather than commiting this version to master and breaking stuff that will be hard to unbreak. I suggest @petermatulis and myself review that branch, raise issues there and we can work through it. I will leave this open though as it does provide a handy diff of changes |
|
Nothing in this pull request removes or deletes anything. We'd appreciate getting this reviewed an in devel docs before 1.26 lands. That said, there are pages we have deprecated, though we have opted not to delete them from the repository yet. |
|
Oh nice! I didn't even catch that. Grammar |
ader1990
and others
added some commits
Dec 2, 2015
|
I merged a contribution from our partners at CloudBase for the powershell equivalent methods! I love collaboration! |
johnsca
and others
added some commits
Dec 7, 2015
|
Addressing @justcfx2u's comments on this doc. #41 (comment) |
evilnick
and others
added some commits
Dec 18, 2015
added a commit
that referenced
this pull request
Jan 4, 2016
marcoceppi
merged commit 7bd0304
into
juju:master
Jan 4, 2016
|
+1 |
|
I'll probably de-merge this today or tomorrow. |
|
Peter, Thanks for the comment and help on the docs. The intent here is to have a development space where folks may collaborate on the new version of the docs. This version is far from a final version and thus is in the development branch. Folks can make small incremental pull requests to the docs and not affect the stable docs. The thought is to collaboratively work on getting the -devel docs in shape for Juju 2.0 (April time frame). I would ask you keep this branch and open an issues or pull requests to get these docs ready for Juju 2.0. We could very much use your expertise in helping shape these docs for Juju 2.0. -thanks, |
mbruzek commentedNov 25, 2015
This adds a developer guide section above the charm authors section in the
navigation. This adds the updated content for developers who want to use layers
and reactive with a focus on the Getting Started Guide and Reference material.
The focus of this PR changes the following:
Please review the attached guide for organization, correctness, cross-file linking
to the reference guide where applicable. You will notice that we did not delete any files at this point. The author section is just moved down in the navigation.