Rewrite charm store docs to new charm tool #975

Merged
merged 1 commit into from Apr 12, 2016

Conversation

Projects
None yet
4 participants
Owner

marcoceppi commented Apr 7, 2016

in process of landing in xenial, in meantime install charm from ppa:juju/devel and ppa:juju/stable

fixes #937

Collaborator

chuckbutler commented Apr 11, 2016

+1 LGTM

Nice diagrams as well, and thanks for explaining channels in here. Solid work.

src/en/authors-charm-store.md
-## Submitting a new Charm
+In order to interact with the charm store you will need the latest
+[charm command](tools-charm-tools.html) and a charm store login.
@urosj

urosj Apr 11, 2016

Owner

For now, to login into charm store, you'll need to have both Ubuntu SSO and Launchpad (LP) account. Due to historical reasons, charm store users the username from LP.

src/en/authors-charm-store.md
+When an entity, a charm or bundle, is pushed for the first time to the store it's
+placed as version 0 in the unpublished channel. Every revision of an entity lives
+in the unpublished channel. Subsequent pushes to the store will automatically
@urosj

urosj Apr 11, 2016

Owner

s/Subsequent pushes/Subsequent pushes of different content

src/en/authors-charm-store.md
+When an entity, a charm or bundle, is pushed for the first time to the store it's
+placed as version 0 in the unpublished channel. Every revision of an entity lives
+in the unpublished channel. Subsequent pushes to the store will automatically
+increment this number. So if an entity is pushed 4 times the revision history
@urosj

urosj Apr 11, 2016

Owner

s/an entity/a different entity

src/en/authors-charm-store.md
+
+```
+
+Channels group revisions into named streams. There are currently to channels:
@urosj

urosj Apr 11, 2016

Owner

s/to channels/two channels

src/en/authors-charm-store.md
+
+Channels group revisions into named streams. There are currently to channels:
+stable and development. Each channel also tracks history of revisions. When a
+revision is published to a channel, that channel pointer is incremented and the
@urosj

urosj Apr 11, 2016

Owner

s/is incremented/is changed

Owner

urosj commented Apr 11, 2016

Some comments, but otherwise LGTM, TY!

Owner

marcoceppi commented Apr 11, 2016

Thanks for the feedback @urosj moving from WIP -> ready review

@marcoceppi marcoceppi changed the title from WIP: Rewrite charm store docs to new charm tool to Rewrite charm store docs to new charm tool Apr 11, 2016

Member

evilnick commented Apr 12, 2016

🍘

@matthewhelmke perhaps you could give this page a once-over after merge :)

@evilnick evilnick merged commit 29e2cc6 into juju:master Apr 12, 2016

@matthewhelmke matthewhelmke referenced this pull request Apr 12, 2016

Merged

Authors charm store #986

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment