package_test.go: tiny fix to panic output #16

Merged
merged 1 commit into from Feb 11, 2015

Conversation

Projects
None yet
3 participants
Member

mattyw commented Feb 6, 2015

No description provided.

package_test.go
@@ -82,7 +82,7 @@ func setLocationsForErrorTags(filename string) {
if j := strings.Index(line, "//err "); j >= 0 {
tag := line[j+len("//err "):]
if _, found := tagToLocation[tag]; found {
- panic(fmt.Errorf("tag %q already processed previously"))
+ panic(fmt.Errorf("tag %q already processed previously", tag))
@davecheney

davecheney Feb 6, 2015

Contributor

Please make this fmt.Printf, here and elsewhere

Member

mattyw commented Feb 6, 2015

@davecheney I assume you meant Sprintf

Contributor

davecheney commented Feb 6, 2015

yup

On Fri, Feb 6, 2015 at 8:41 PM, Matt Williams notifications@github.com
wrote:

@davecheney https://github.com/davecheney I assume you meant Sprintf


Reply to this email directly or view it on GitHub
#16 (comment).

Contributor

fwereade commented Feb 11, 2015

LGTM

Contributor

fwereade commented Feb 11, 2015

$$merge$$

fwereade added a commit that referenced this pull request Feb 11, 2015

Merge pull request #16 from mattyw/minor-panic-fix
package_test.go: tiny fix to panic output

@fwereade fwereade merged commit 036046b into juju:master Feb 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment