/gomaasapi

VLAN name is optional in 2.0 API schema #42

Merged
merged 2 commits into from Apr 18, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@dimitern @babbageclunk @jujubot
@dimitern
Contributor

dimitern commented Apr 17, 2016 •
Edited 1 time

Discovered while trying to bootstrap with Juju on MAAS 2.0.
With this fix the bootstrap almost completes, but at least goes further. completes OK,
after increasing the bootstrap-timeout to 1200 (from the default 600)! Hardware NUCs
seem to need a bit more time than KVM nodes.
@babbageclunk
Member

babbageclunk commented Apr 18, 2016

Looks good! Do you think it's worth adding a test case for this?
@dimitern
Contributor

dimitern commented Apr 18, 2016

Thanks! Added tests as suggested.
@dimitern
Contributor

dimitern commented Apr 18, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Apr 18, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-gomaasapi

@jujubot jujubot merged commit 6c205e4 into juju:master Apr 18, 2016

@dimitern dimitern deleted the dimitern:gomaasapi-fix-vlan-name-schema branch Apr 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment