/gomaasapi

Make dns_servers optional in subnets #44

Merged
merged 2 commits into from Apr 21, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@voidspace @dimitern @jujubot
@voidspace
Contributor

voidspace commented Apr 21, 2016

Make dns_servers optional in the subnets response from MAAS 2.
subnet_test.go
@@ -86,7 +86,6 @@ var subnetResponse = `
"space": "space-0",
"id": 34,
"resource_uri": "/MAAS/api/2.0/subnets/34/",
- "dns_servers": [],
@dimitern

dimitern Apr 21, 2016

Contributor

How about explicitly using "dns_server": null above instead? Can it be null coming from MAAS or it's just omitted?

@voidspace

voidspace Apr 21, 2016

Contributor

I've checked the output - and the problematic one is "null", so I've updated the test.

@dimitern
Contributor

dimitern commented Apr 21, 2016

LGTM, thanks!
@voidspace
Contributor

voidspace commented Apr 21, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Apr 21, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-gomaasapi

@jujubot jujubot merged commit f5c86a2 into juju:master Apr 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment