Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Use the correct VLAN in machine.CreateDevice #47
Conversation
added some commits
Apr 27, 2016
babbageclunk
reviewed
Apr 27, 2016
| @@ -270,6 +270,7 @@ func (s *machineSuite) TestCreateDevice(c *gc.C) { | ||
| }) | ||
| c.Assert(err, jc.ErrorIsNil) | ||
| c.Assert(device.InterfaceSet()[0].Name(), gc.Equals, "eth4") | ||
| + c.Assert(device.InterfaceSet()[0].VLAN().ID(), gc.Equals, subnet.VLAN().ID()) |
babbageclunk
Apr 27, 2016
Member
I tried to chase it down to check, but are you sure the subnet vlan id was different from the interface vlan id to start with? Did this fail before the fix?
|
Looks good to me! |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-gomaasapi |
jujubot
merged commit 794d847
into
juju:master
Apr 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
voidspace commentedApr 27, 2016
machine.CreateDevice was using the wrong VLAN in the update call.