Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Update for more potential nils. #53
Conversation
mjs
reviewed
May 2, 2016
| @@ -270,15 +274,16 @@ func device_2_0(source map[string]interface{}) (*device, error) { | ||
| if err != nil { | ||
| return nil, errors.Trace(err) | ||
| } | ||
| - | ||
| + owner, _ := valid["owner"].(string) |
mjs
commented
May 2, 2016
|
LGTM |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-gomaasapi |
jujubot
merged commit 8d0fc40
into
juju:master
May 2, 2016
howbazaar
deleted the
howbazaar:more-nils
branch
May 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
howbazaar commentedMay 2, 2016
Instead of the hit and miss approach we have done so far, I went through the maas source code as well as I could and looked for any of the DB fields that could be null.
I have added defaults for the possible nulls in the off chance that at some stage in the future the maas api starts omitting them.