/gomaasapi

Expose block device id_path attribute #69

Merged
merged 1 commit into from Apr 18, 2017

Conversation

Reviewers

@jameinel jameinel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@axw @jujubot @jameinel
@axw
Member

axw commented Apr 18, 2017

id_path is the attribute we should be using
in Juju as a stable path identifier for block
devices. The value for "path", which we have
been using, is not always accurate.
@axw
Expose block device id_path attribute 
id_path is the attribute we should be using
in Juju as a stable path identifier for block
devices. The value for "path", which we have
been using, is not always accurate.
This commit was signed with a verified signature.
@axw axw Andrew Wilkins
GPG key ID: 55314F7628952B05 Learn about signing commits
80c7f72
@jameinel

jameinel approved these changes Apr 18, 2017
View changes

assuming that this data has always been there and we've just been ignoring it, LGTM

Also, assuming you've tried this live.

@axw
Member

axw commented Apr 18, 2017

assuming that this data has always been there and we've just been ignoring it, LGTM

Yep.

Also, assuming you've tried this live.

Yep.
@axw
Member

axw commented Apr 18, 2017

$$merge$$
@jujubot
Contributor

jujubot commented Apr 18, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-gomaasapi

@jujubot jujubot merged commit 38cd919 into juju:master Apr 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment