/govmomi forked from vmware/govmomi

Support Go 1.2. #1

Merged
merged 1 commit into from Apr 24, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ericsnowcurrently @wallyworld
@ericsnowcurrently

ericsnowcurrently commented Apr 23, 2015

Tested against the vmware patch.
vim25/soap/client.go
+ if err != nil {
+ return conn, err
+ }
+ if tc, ok := conn.(*net.TCPConn); ok {
@wallyworld

wallyworld Apr 24, 2015

Owner

please comment this block to indicate why this is all necessary

@wallyworld
Owner

wallyworld commented Apr 24, 2015

LGTM so long as it's been tested

ericsnowcurrently added a commit that referenced this pull request Apr 24, 2015

@ericsnowcurrently
Merge pull request #1 from ericsnowcurrently/support-go-1.2 
Support Go 1.2.
b64373b

@ericsnowcurrently ericsnowcurrently merged commit b64373b into juju:master Apr 24, 2015

@ericsnowcurrently ericsnowcurrently deleted the ericsnowcurrently:support-go-1.2 branch Apr 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment