Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update schema based on actual usage #2

Merged
merged 1 commit into from Nov 2, 2016
Merged

Update schema based on actual usage #2

merged 1 commit into from Nov 2, 2016

Conversation

natefinch
Copy link
Contributor

No description provided.

bz2
bz2 approved these changes Nov 2, 2016
View reviewed changes
Copy link

@bz2 bz2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes are fine, no comment on the design considerations (apart for the note about plural forms being more complicated than this in other languages).

@natefinch
Copy link
Contributor Author

$$merge$$

@jujubot
Copy link
Contributor

jujubot commented Nov 2, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-jsonschema

@jujubot jujubot merged commit a0ef8b7 into juju:master Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bz2 bz2 bz2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@natefinch @jujubot @bz2