Cross model relations: offer details and remote service info. #1091

Merged
merged 1 commit into from Dec 17, 2015

Conversation

Projects
None yet
3 participants
Member

frankban commented Dec 16, 2015

Implement the missing ServiceOffers API call on the CrossModelRelations
facade. It is used to retrieve details on a offered remote service.

Also implement the model layer for remote services. It is represented
in the database by a RemoteService model, and its corresponding
model list.

A mega-watcher handler is also introduced in order to populate the
new models. As juju-core does not yet implement relating to remote
services it is not possible to really test the mega-watcher handler
at this time, but I followed to Go code and that logic should be
ready very soon anyway.

Finally, added an addDetails method on the RemoteService that can be
use to enhance the model instance (created on delta) with info
obtained from calling env.getOffer().

Note that sandbox mode is not supported yet.

I expect small tweaks will be required when the functionality is
completed in core, but for now this should be enough for proceeding
with visualization steps.

Cross model relations: offer details and remote service info.
Implement the missing ServiceOffers API call on the CrossModelRelations
facade. It is used to retrieve details on a offered remote service.

Also implement the model layer for remote services. It is represented
in the database by a RemoteService model, and its corresponding
model list.

A mega-watcher handler is also introduced in order to populate the
new models. As juju-core does not yet implement relating to remote
services it is not possible to really test the mega-watcher handler
at this time, but I followed to Go code and that logic should be
ready very soon anyway.

Finally, added an addDetails method on the RemoteService that can be
use to enhance the model instance (created on delta) with info
obtained from calling env.getOffer().

Note that sandbox mode is not supported yet.

I expect small tweaks will be required when the functionality is
completed in core, but for now this should be enough for proceeding
with visualization steps.
Member

jujugui commented Dec 16, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/juju-gui/3926/
Test PASSed.

Owner

hatched commented Dec 17, 2015

👍 Looks great! Can't wait to actually use it :)

Member

frankban commented Dec 17, 2015

Thanks for the review!
:shipit:

Member

jujugui commented Dec 17, 2015

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge

jujugui added a commit that referenced this pull request Dec 17, 2015

Merge pull request #1091 from frankban/more-cmr-api
Cross model relations: offer details and remote service info.

Implement the missing ServiceOffers API call on the CrossModelRelations
facade. It is used to retrieve details on a offered remote service.

Also implement the model layer for remote services. It is represented
in the database by a RemoteService model, and its corresponding
model list.

A mega-watcher handler is also introduced in order to populate the
new models. As juju-core does not yet implement relating to remote
services it is not possible to really test the mega-watcher handler
at this time, but I followed to Go code and that logic should be
ready very soon anyway.

Finally, added an addDetails method on the RemoteService that can be
use to enhance the model instance (created on delta) with info
obtained from calling env.getOffer().

Note that sandbox mode is not supported yet.

I expect small tweaks will be required when the functionality is
completed in core, but for now this should be enough for proceeding
with visualization steps.

@jujugui jujugui merged commit 8da3a2d into juju:develop Dec 17, 2015

1 check passed

default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment