Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Cross model relations: offer details and remote service info. #1091
Conversation
|
Test PASSed. |
|
|
|
Thanks for the review! |
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
added a commit
that referenced
this pull request
Dec 17, 2015
jujugui
merged commit 8da3a2d
into
juju:develop
Dec 17, 2015
1 check passed
default
Merged build finished.
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
frankban commentedDec 16, 2015
Implement the missing ServiceOffers API call on the CrossModelRelations
facade. It is used to retrieve details on a offered remote service.
Also implement the model layer for remote services. It is represented
in the database by a RemoteService model, and its corresponding
model list.
A mega-watcher handler is also introduced in order to populate the
new models. As juju-core does not yet implement relating to remote
services it is not possible to really test the mega-watcher handler
at this time, but I followed to Go code and that logic should be
ready very soon anyway.
Finally, added an addDetails method on the RemoteService that can be
use to enhance the model instance (created on delta) with info
obtained from calling env.getOffer().
Note that sandbox mode is not supported yet.
I expect small tweaks will be required when the functionality is
completed in core, but for now this should be enough for proceeding
with visualization steps.