Add support for grouping promulgated bundles as recommended #160

Merged
merged 1 commit into from Mar 5, 2014

Conversation

Projects
None yet
3 participants
Owner

mitechie commented Mar 5, 2014

Search should show promulgated bundles as recommended.

To QA:

Load the gui and search for "bundle" as the keyword. There should be one result that comes back as recommended and the charm token shows it as a recommended bundle.

Member

jujugui commented Mar 5, 2014

Test FAILed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/506/

Member

jujugui commented Mar 5, 2014

Test PASSed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/507/

@hatched hatched commented on an outdated diff Mar 5, 2014

app/models/bundle.js
@@ -125,6 +125,26 @@ YUI.add('juju-bundle-models', function(Y) {
id: {},
name: {},
description: {},
+ /**
+ For charms the api returns is_approved and we want to share that
+ across our templates. This maps to the promulgated api data from the
+ bundle results.
+
+ @attribute is_approved
+ @default false
+ @type {Boolean}
+
@hatched

hatched Mar 5, 2014

Owner

extra space

@hatched hatched commented on the diff Mar 5, 2014

app/models/bundle.js
+ For charms the api returns is_approved and we want to share that
+ across our templates. This maps to the promulgated api data from the
+ bundle results.
+
+ @attribute is_approved
+ @default false
+ @type {Boolean}
+
+ */
+ is_approved: {
+ /**
+ Reach into the promulgated attr
+
+ @method getter
+ */
+ getter: function() {
@hatched

hatched Mar 5, 2014

Owner

If you didn't want to doc this you can quote the method name 'getter'

@hatched hatched commented on an outdated diff Mar 5, 2014

app/subapps/browser/views/search.js
@@ -169,13 +169,24 @@ YUI.add('subapp-browser-searchview', function(Y) {
series = DEFAULT_SEARCH_SERIES;
}
results.map(function(charm) {
@hatched

hatched Mar 5, 2014

Owner

charm should probably be entity

Owner

hatched commented Mar 5, 2014

Thanks for adding this!
👍 with trivials
QA OK!

Owner

mitechie commented Mar 5, 2014

Thanks for the review. Updated :shipit:

Member

jujugui commented Mar 5, 2014

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge

jujugui merged commit 895aa48 into juju:develop Mar 5, 2014

1 check failed

default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment