Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realign inspector breakout panel to come from left #261

Merged
merged 1 commit into from Apr 24, 2014

Conversation

Projects
None yet
3 participants
@mitechie
Copy link
Member

commented Apr 24, 2014

This is a first step. The changes here break some of the ideas of the
viewlet-manager and viewlets. There are work arounds in place here so that we
can move forward and discuss how to adjust to the requirements here.

  • Updates the unit and service details to come into the same space as charm
    details.
  • Works around the issue of the close event not being in the same dom tree as
    the viewlet-manager and not caught to close the breakout panels.
  • Updates the css for the new location.

QA

  • make devel
  • view the site with 馃帍/il
  • deploy a service and once it's deployed, click on the "Charm details" link and
    a functional details popout should appear.
  • Close and verify it closes properly and reopens as well.
  • Go to a running unit and select the unit to open its details.
  • Verify you can go straight from a unit to a service details and back/forth
    without issue.
  • Verify that with a panel open, if you close the inspector the panel also
    closes.
  • Verify that the inspector and panels work without the feature flag as
    expected.
@jujugui

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2014

Test PASSed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/804/

@huwshimi

This comment has been minimized.

Copy link
Member

commented Apr 24, 2014

QA OK

Realign inspector breakout panel to come from left
This is a first step. The changes here break some of the ideas of the
viewlet-manager and viewlets. There are work arounds in place here so that we
can move forward and discuss how to adjust to the requirements here.

- Updates the unit and service details to come into the same space as charm
details.
- Works around the issue of the close event not being in the same dom tree as
the viewlet-manager and not caught to close the breakout panels.
- Updates the css for the new location.

QA
---

- make devel
- view the site with 馃帍/il
- deploy a service and once it's deployed, click on the "Charm details" link and
  a functional details popout should appear.
- Close and verify it closes properly and reopens as well.
- Go to a running unit and select the unit to open its details.
- Verify you can go straight from a unit to a service details and back/forth
  without issue.
- Verify that with a panel open, if you close the inspector the panel also
  closes.
- Verify that the inspector and panels work without the feature flag as
  expected.
@mitechie

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2014

thanks for the qa. :shipit:

@jujugui

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2014

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge

@jujugui

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2014

Test PASSed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/805/

jujugui added a commit that referenced this pull request Apr 24, 2014

Merge pull request #261 from mitechie/qa-inspector-panels
This is a first step. The changes here break some of the ideas of the
viewlet-manager and viewlets. There are work arounds in place here so that we
can move forward and discuss how to adjust to the requirements here.

- Updates the unit and service details to come into the same space as charm
details.
- Works around the issue of the close event not being in the same dom tree as
the viewlet-manager and not caught to close the breakout panels.
- Updates the css for the new location.

QA
---

- make devel
- view the site with 馃帍/il
- deploy a service and once it's deployed, click on the "Charm details" link and
  a functional details popout should appear.
- Close and verify it closes properly and reopens as well.
- Go to a running unit and select the unit to open its details.
- Verify you can go straight from a unit to a service details and back/forth
  without issue.
- Verify that with a panel open, if you close the inspector the panel also
  closes.
- Verify that the inspector and panels work without the feature flag as
  expected.

@jujugui jujugui merged commit 36fdddb into juju:develop Apr 24, 2014

1 check passed

default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.