Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Payment forms in the deployment flow #2675
Conversation
huwshimi
added
enhancement
Review: Needed
labels
Mar 24, 2017
huwshimi
added this to the
fabulous fontaine milestone
Mar 24, 2017
huwshimi
self-assigned this
Mar 24, 2017
|
QA:
|
|
Refer to this link for build results (access rights to CI server needed): |
| + required={false} /> | ||
| + <juju.components.GenericInput | ||
| + disabled={disabled} | ||
| + label="County (optional)" |
fabricematrat
Mar 27, 2017
Member
I think calling it State/Province might be less confusing, I had so many confusion in the payment service.
| + @method _generateBusinessNameField | ||
| + */ | ||
| + _generateBusinessNameField: function() { | ||
| + if (!this.state.business) { |
fabricematrat
Mar 27, 2017
Member
May be we need to make sure if a business name is entered, a VAT is provided ?
fabricematrat
approved these changes
Mar 27, 2017
Code LGTM, with suggestions (take it or leave it.)
| + disabled={disabled} | ||
| + label="Country code" | ||
| + onChange={null} | ||
| + options={[]} /> |
| + @method _generateBusinessNameField | ||
| + */ | ||
| + _generateBusinessNameField: function() { | ||
| + if (!this.state.business) { |
fabricematrat
Mar 27, 2017
Member
May be we need to make sure if a business name is entered, a VAT is provided ?
hatched
removed
the
Review: Needed
label
Mar 27, 2017
huwshimi
added some commits
Mar 24, 2017
|
Refer to this link for build results (access rights to CI server needed): |
|
Thanks @fabricematrat, @hatched |
|
Status: merge request accepted. Url: http://ci-gce.jujugui.org:8080/job/juju-gui-merge |
huwshimi commentedMar 24, 2017
No description provided.