Payment forms in the deployment flow #2675

Merged
merged 3 commits into from Mar 28, 2017

Conversation

Projects
None yet
4 participants
Member

huwshimi commented Mar 24, 2017

No description provided.

@huwshimi huwshimi added this to the fabulous fontaine milestone Mar 24, 2017

@huwshimi huwshimi self-assigned this Mar 24, 2017

Member

huwshimi commented Mar 24, 2017

QA:

  • if you know what you're doing, open the deployment flow and if you have no user for this stuff you should see the form
Member

jujugui commented Mar 24, 2017

Refer to this link for build results (access rights to CI server needed):
http://ci-cge.jujugui.org:8080//job/juju-gui/6997/

+ required={false} />
+ <juju.components.GenericInput
+ disabled={disabled}
+ label="County (optional)"
@fabricematrat

fabricematrat Mar 27, 2017

Member

I think calling it State/Province might be less confusing, I had so many confusion in the payment service.

+ @method _generateBusinessNameField
+ */
+ _generateBusinessNameField: function() {
+ if (!this.state.business) {
@fabricematrat

fabricematrat Mar 27, 2017

Member

May be we need to make sure if a business name is entered, a VAT is provided ?

@hatched

hatched Mar 27, 2017

Owner

That would only be necessary for countries in which VAT is a thing :)

Code LGTM, with suggestions (take it or leave it.)

+ disabled={disabled}
+ label="Country code"
+ onChange={null}
+ options={[]} />
@hatched

hatched Mar 27, 2017

Owner

I'm guessing this gets fetched in the other branch?

+ @method _generateBusinessNameField
+ */
+ _generateBusinessNameField: function() {
+ if (!this.state.business) {
@fabricematrat

fabricematrat Mar 27, 2017

Member

May be we need to make sure if a business name is entered, a VAT is provided ?

@hatched

hatched Mar 27, 2017

Owner

That would only be necessary for countries in which VAT is a thing :)

@hatched hatched removed the Review: Needed label Mar 27, 2017

Member

jujugui commented Mar 28, 2017

Refer to this link for build results (access rights to CI server needed):
http://ci-cge.jujugui.org:8080//job/juju-gui/7016/

Member

huwshimi commented Mar 28, 2017

Member

jujugui commented Mar 28, 2017

Status: merge request accepted. Url: http://ci-gce.jujugui.org:8080/job/juju-gui-merge

@jujugui jujugui merged commit 98a640e into juju:develop Mar 28, 2017

1 check passed

default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment