Add sysdeps target #690

Merged
merged 3 commits into from Jan 30, 2015

Conversation

Projects
None yet
4 participants
Member

makyo commented Jan 29, 2015

This will allow you to bring up a box or a container with the system dependencies required for building the GUI.

Member

makyo commented Jan 29, 2015

QA

  • Bring up a new LXC
  • install git and make (depending on your lxc template)
  • git clone https://github.com/makyo/juju-gui.git
  • cd juju-gui
  • git checkout sysdeps
  • sudo make sysdeps
  • Ensure that make build completes successfully
Member

jujugui commented Jan 29, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/juju-gui/2353/
Test PASSed.

+npm install -g jshint@2.1.3 mocha-phantomjs@3.3.1 phantomjs@1.9.2-6
@huwshimi

huwshimi Jan 29, 2015

Member

The way this file is run will result in a sudo npm install -g ... which I thought was a bad idea, but I'm not sure if there's anything we an do about it.

@hatched

hatched Jan 29, 2015

Owner

I am running newer versions in my non qa-for-this-lxc so maybe we should update these at some point

Member

huwshimi commented Jan 29, 2015

Much nicer, thanks @makyo QA OK 👍

Owner

hatched commented Jan 29, 2015

👍 QA OK - this is awesome.
I followed the steps as outlined and then ran the following make commands prod, devel, test-prod, test-devel and all worked as intended.

Owner

hatched commented Jan 29, 2015

I'd probably rename the 'vagrant' file now though

Member

jujugui commented Jan 30, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/juju-gui/2354/
Test PASSed.

Member

makyo commented Jan 30, 2015

:shipit: Thanks

Member

jujugui commented Jan 30, 2015

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge

jujugui added a commit that referenced this pull request Jan 30, 2015

Merge pull request #690 from makyo/sysdeps
Add sysdeps target

This will allow you to bring up a box or a container with the system dependencies required for building the GUI.

@jujugui jujugui merged commit 6e56d16 into juju:develop Jan 30, 2015

1 check passed

default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment