Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add options parsing for charmstore api v4 #691
Conversation
hatched
added some commits
Feb 3, 2015
To QADrag a charm to the canvas from the charmbrowser |
|
Test FAILed. |
|
Looks good, thanks Jeff. QA OK |
|
Thanks @huwshimi After a few tries CI passed: http://ci.jujugui.org:8080/job/juju-gui/2358/ |
|
|
|
Thanks for the reviews! |
|
Build failed: Attempt to land pull request failed |
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
hatched commentedFeb 3, 2015
Fix for bug: https://bugs.launchpad.net/juju-gui/+bug/1416469
When the user drag & dropped a charm from the charmbrowser it wasn't requesting and storing any charm configuration options so when trying to export it would fail as the options object was empty.