Add options parsing for charmstore api v4 #691

Merged
merged 2 commits into from Feb 4, 2015

Conversation

Projects
None yet
4 participants
Owner

hatched commented Feb 3, 2015

Fix for bug: https://bugs.launchpad.net/juju-gui/+bug/1416469

When the user drag & dropped a charm from the charmbrowser it wasn't requesting and storing any charm configuration options so when trying to export it would fail as the options object was empty.

Owner

hatched commented Feb 3, 2015

To QA

Drag a charm to the canvas from the charmbrowser
Switch to the Machine View and autoplace the charm
Deploy & Confirm the changes
Click export and it should download the bundle yaml file.

Member

jujugui commented Feb 3, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/juju-gui/2356/
Test FAILed.

Member

huwshimi commented Feb 3, 2015

Looks good, thanks Jeff. QA OK 👍

Owner

hatched commented Feb 3, 2015

Thanks @huwshimi

After a few tries CI passed: http://ci.jujugui.org:8080/job/juju-gui/2358/

Member

frankban commented Feb 4, 2015

👍 thank you!

Owner

hatched commented Feb 4, 2015

Thanks for the reviews! :shipit:

Member

jujugui commented Feb 4, 2015

Build failed: Attempt to land pull request failed
build url: http://ci.jujugui.org:8080/job/juju-gui-merge/821

Member

jujugui commented Feb 4, 2015

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge

jujugui added a commit that referenced this pull request Feb 4, 2015

Merge pull request #691 from hatched/export-yaml-1416469
Add options parsing for charmstore api v4

Fix for bug: https://bugs.launchpad.net/juju-gui/+bug/1416469
 
When the user drag & dropped a charm from the charmbrowser it wasn't requesting and storing any charm configuration options so when trying to export it would fail as the options object was empty.

@jujugui jujugui merged commit 1314507 into juju:develop Feb 4, 2015

1 check failed

default Merged build finished.
Details

@hatched hatched deleted the hatched:export-yaml-1416469 branch Feb 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment