Downconvert apiv4 bundle yaml to apiv3 format temporarily #700

Merged
merged 2 commits into from Mar 6, 2015

Conversation

Projects
None yet
4 participants
Owner

hatched commented Mar 5, 2015

Some apiv3 baskets still have multiple bundles in them. To combat this we are switching to using the apiv4 bundle yaml instead of the apiv3 bundle yaml and then wrapping it to make it appear to be the apiv3 format.

Owner

hatched commented Mar 5, 2015

To QA

Test 1: http://localhost:8888/?deploy-target=bundle/rails-example-scalable-6
This should deploy a large complex bundle, not a simple 2 charm bundle.
Test 2: Click on a bundle in the charmbrowser and click the "deploy bundle" button
If it deployed then it's ok.
Test 3: Drag a bundle from the charmbrowser to the canvas
If it deployed then it's ok.

Member

makyo commented Mar 5, 2015

👍 QA okay, all bundles worked as expected.

Member

jujugui commented Mar 5, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/juju-gui/2386/
Test FAILed.

Owner

hatched commented Mar 5, 2015

Spurious failure - these are becoming not so spurious

Member

huwshimi commented Mar 6, 2015

Looks good @hatched, I assume we've already updated the api request to v4 somewhere? 👍 No QA.

Owner

hatched commented Mar 6, 2015

:shipit:

Member

jujugui commented Mar 6, 2015

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge

jujugui added a commit that referenced this pull request Mar 6, 2015

Merge pull request #700 from hatched/upconvert-bundle-yaml
Downconvert apiv4 bundle yaml to apiv3 format temporarily

Some apiv3 baskets still have multiple bundles in them. To combat this we are switching to using the apiv4 bundle yaml instead of the apiv3 bundle yaml and then wrapping it to make it appear to be the apiv3 format.

@jujugui jujugui merged commit a6eab35 into juju:develop Mar 6, 2015

1 check failed

default Merged build finished.
Details

@hatched hatched deleted the hatched:upconvert-bundle-yaml branch Mar 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment