Removed the features tab and related code from the charm and bundles details pages #705

Merged
merged 1 commit into from Mar 12, 2015

Conversation

Projects
None yet
4 participants
Owner

hatched commented Mar 11, 2015

This information is no longer relevant with the apiv4 endpoint so it's being removed.

Owner

hatched commented Mar 11, 2015

To QA

View the charm and bundle details panes and make sure that you can still navigate around them as expected and that the features tab doesn't exist.

@hatched hatched closed this Mar 11, 2015

@hatched hatched reopened this Mar 11, 2015

Member

jujugui commented Mar 11, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/juju-gui/2406/
Test PASSed.

Member

jujugui commented Mar 11, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/juju-gui/2407/
Test FAILed.

Member

huwshimi commented Mar 12, 2015

Looks good @hatched, thanks for removing the CSS as well! 👍

NO QA as I'm getting merge conflicts with develop.

Member

makyo commented Mar 12, 2015

👍 QA okay. No features, no errors in the console.

Owner

hatched commented Mar 12, 2015

Thanks guys! :shipit:

Member

jujugui commented Mar 12, 2015

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge

jujugui added a commit that referenced this pull request Mar 12, 2015

Merge pull request #705 from hatched/remove-features
Removed the features tab and related code from the charm and bundles details pages

This information is no longer relevant with the apiv4 endpoint so it's being removed.

@jujugui jujugui merged commit 8debccc into juju:develop Mar 12, 2015

1 check failed

default Merged build finished.
Details

@hatched hatched deleted the hatched:remove-features branch Mar 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment