Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Get related charms from charmstore apiv4 #706
Conversation
hatched
added some commits
Mar 11, 2015
To QAOpen the charm details page Related Charms tab, it should list out the related charm icons. |
|
Test FAILed. |
|
Test PASSed. |
makyo
reviewed
Mar 16, 2015
| - allCharmsList.sort(function(charm1, charm2) { | ||
| - return charm2.weight - charm1.weight; | ||
| + /** | ||
| + Splits charm list into a key value delimited list of charms. |
makyo
reviewed
Mar 16, 2015
| + @param {Array} indexes The list of id's for the charm list. It's an | ||
| + integer list. | ||
| + @param {String} name The interface name that the charms are sorted under. | ||
| + @param {Object} charmList The full requires or provides interfact ordered |
|
This looks great, much simpler. |
|
QA looks good on most charms, but not http://localhost:8888/precise/ubuntu-4/#related-charms because Object.keys is being called on a non-object, charm.js:278 |
|
Thanks for the review and QA @makyo this should be fixed now, you can try with |
|
Much better, thanks! |
|
Test PASSed. |
|
Thanks @hatched I think it looks all good |
|
Thanks for the reviews and qa's! |
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
added a commit
that referenced
this pull request
Mar 17, 2015
hatched commentedMar 13, 2015
The format of responded data from the charmstore apiv3 and v4 were completely different so the parsing implementation needed to be rewritten.