Fix service icon bounceback when dragging on canvas #707

Merged
merged 1 commit into from Mar 16, 2015

Conversation

Projects
None yet
5 participants
Owner

hatched commented Mar 16, 2015

This fixes an issue where the service icons would bounce back to their original positions while the user was dragging them around.

Remove timout in setting position annotations which was causing a 'bo…
…unceback' bug when dragging during a delta update
Owner

hatched commented Mar 16, 2015

Note: Tests already existed for this functionality but did not exist for the timer functionality so no new tests are needed.

To QA

Deploy to a real environment - LXC is fine but the slower the env the better.
On the canvas, click and drag the service icon around in short bursts ~1s for 30s. If it doesn't snap back to its original position then you're ok.

Member

jujugui commented Mar 16, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/juju-gui/2411/
Test PASSed.

Collaborator

bac commented Mar 16, 2015

Code is 👍 but I have my machine tied up right now and cannot do QA.

Member

makyo commented Mar 16, 2015

Code LGTM, QAing now.

Member

makyo commented Mar 16, 2015

QA okay - deployed the GUI and NFS, dragged them around for a while, individually, then alternating. 👍

One thing I noticed is that, with the deltas coming back, the service health graph on an unplaced service goes up and down as I'm dragging it about in short bursts. It's almost as if each time a delta comes back, it decides whether or not to display as unplaced. Not for this branch and low priority, just something to keep an eye on.

Owner

hatched commented Mar 16, 2015

Thanks for the reviews and qa! @makyo can you create a low priority bug just so that we can track it? Thanks again!

:shipit:

Member

jujugui commented Mar 16, 2015

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge

jujugui added a commit that referenced this pull request Mar 16, 2015

Merge pull request #707 from hatched/no-more-bounceback
Fix service icon bounceback when dragging on canvas

This fixes an issue where the service icons would bounce back to their original positions while the user was dragging them around.

@jujugui jujugui merged commit e5fac66 into juju:develop Mar 16, 2015

1 check passed

default Merged build finished.
Details

dear @hatched, thank you for this

Owner

hatched commented Mar 17, 2015

@chuckbutler No Problem! :) A release with this fix (and others) will be coming soon as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment