Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fix service icon bounceback when dragging on canvas #707
Conversation
|
Note: Tests already existed for this functionality but did not exist for the timer functionality so no new tests are needed. To QADeploy to a real environment - LXC is fine but the slower the env the better. |
|
Test PASSed. |
|
Code is |
|
Code LGTM, QAing now. |
|
QA okay - deployed the GUI and NFS, dragged them around for a while, individually, then alternating. One thing I noticed is that, with the deltas coming back, the service health graph on an unplaced service goes up and down as I'm dragging it about in short bursts. It's almost as if each time a delta comes back, it decides whether or not to display as unplaced. Not for this branch and low priority, just something to keep an eye on. |
|
Thanks for the reviews and qa! @makyo can you create a low priority bug just so that we can track it? Thanks again!
|
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
added a commit
that referenced
this pull request
Mar 16, 2015
jujugui
merged commit e5fac66
into
juju:develop
Mar 16, 2015
1 check passed
chuckbutler
commented
Mar 17, 2015
|
dear @hatched, thank you for this |
|
@chuckbutler No Problem! :) A release with this fix (and others) will be coming soon as well. |
hatched commentedMar 16, 2015
This fixes an issue where the service icons would bounce back to their original positions while the user was dragging them around.