/juju-gui

Parse a constraints string in prepareConstraints #821

Merged
merged 1 commit into from Sep 3, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@makyo @frankban @jujugui @hatched
@makyo
Member

makyo commented Sep 3, 2015

No description provided.

@makyo
Member

makyo commented Sep 3, 2015

QA

  • make run
  • Set a breakpoint at app/store/env/go.js:1022
  • drag and drop http://pastebin.com/ULBjUtiy onto the canvas
  • Ensure that request.Params.Constraints.tags exists and is an array
Makefile
@@ -75,13 +75,13 @@ $(PY):
$(NODE_MODULES):
npm install --cache-min 999999
-.PHONY: run-server
-run-server: gui
+.PHONY: server
@makyo

makyo Sep 3, 2015

Member

Drive-by per discussion

Makefile
-run:
- make -j 2 run-server watch
+run: gui
+ $(MAKE) -j2 server watch
@makyo

makyo Sep 3, 2015

Member

Use this make process to start two additional threads.

@frankban
Member

frankban commented Sep 3, 2015

👍
@jujugui
Member

jujugui commented Sep 3, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/juju-gui/2864/
Test PASSed.
@hatched
Owner

hatched commented Sep 3, 2015

👍 QA OK!
@makyo
Member

makyo commented Sep 3, 2015

TY :shipit:
@jujugui
Member

jujugui commented Sep 3, 2015

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge

jujugui added a commit that referenced this pull request Sep 3, 2015

@jujugui
Merge pull request #821 from makyo/fix-constraints 
Parse a constraints string in prepareConstraints
07eaa12

@jujugui jujugui merged commit 07eaa12 into juju:pyramid-fork Sep 3, 2015
1 check passed

1 check passed

default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment