Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more acceptance tests from ./assess helper #10158

Merged
merged 1 commit into from May 10, 2019

Conversation

Projects
None yet
3 participants
@timClicks
Copy link
Member

commented May 9, 2019

Description of change

Juju's acceptance tests use several variants in their command-line arguments. This change teaches the acceptancetests/assess helper script about almost all of them. assess_heterogenous_control.py is particularly idiosyncratic and has been deferred to a future commit.

QA steps

n/a (developer-facing only)

Documentation changes

n/a (developer-facing only)

Bug reference

None.

@wallyworld
Copy link
Member

left a comment

Great, ty

Remember, land in 2.6 please

help="Provider for CaaS models. (Relevant only for caas_deploy_charms test) [default: microk8s]",
choices=["microk8s", "k8s"])
pass_through.add_argument('--caas-image-repo',
help="Docker image repo to use. (Relevant only for caas_deploy_charms test) [default: jujuqabot]",

This comment has been minimized.

Copy link
@wallyworld

wallyworld May 9, 2019

Member

This is relevant for any caas test. As is --caas-provider etc. We only have one test now but are adding more. Can we reword to be more generic.
Not sure if there's other examples also that are currently a little too specific.

This comment has been minimized.

Copy link
@timClicks

timClicks May 9, 2019

Author Member

Have created a new section.


testrun_argv += ["--agent-stream", args.agent_stream]

assess = args.assess

This comment has been minimized.

Copy link
@wallyworld

wallyworld May 9, 2019

Member

Can we add a big comment that the below test specific behaviour is only for tests which use bespoke args for that test; tests which just use generic args are not listed etc etc

This comment has been minimized.

Copy link
@timClicks

timClicks May 9, 2019

Author Member

Sure, done.

@timClicks timClicks force-pushed the timClicks:support-more-ci-tests branch from 98bb443 to e4d172d May 9, 2019

@timClicks

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

$$merge$$

@jujubot jujubot merged commit ca961c0 into juju:develop May 10, 2019

0 of 2 checks passed

check-multi-juju CI Run in progress
Details
merge-multi-juju CI Run in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.