Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsphere: Specify the target datastore when cloning the template #10714

Merged

Conversation

@babbageclunk
Copy link
Member

babbageclunk commented Oct 10, 2019

Description of change

Cloning a template VM wasn't respecting the root-disk-source constraint. That meant the VM would be created in the same datastore as the template, which could be different from the requested datastore if the template already existed.

Pull the datastore selection up so that the selected datastore can be used when cloning the template.

QA steps

  • Bootstrap a vsphere controller with datastore1.
  • Deploy an app with `--constraints "root-disk-source=datastore2" - the deployed VM should be on datastore 2.
  • Deploy another one to datastore 3 and ensure that the new VM is in the right datastore.

Documentation changes

None

Bug reference

Fixes https://bugs.launchpad.net/juju/+bug/1847278

Without this the VM will be created in the same datastore as the
template, which might be different from the requested datastore if the
template already exists.
@babbageclunk

This comment has been minimized.

Copy link
Member Author

babbageclunk commented Oct 10, 2019

$$merge$$

2 similar comments
@babbageclunk

This comment has been minimized.

Copy link
Member Author

babbageclunk commented Oct 10, 2019

$$merge$$

@babbageclunk

This comment has been minimized.

Copy link
Member Author

babbageclunk commented Oct 10, 2019

$$merge$$

@jujubot jujubot merged commit 303f3d5 into juju:2.6 Oct 10, 2019
1 of 2 checks passed
1 of 2 checks passed
merge-multi-juju Build started for merge commit.
Details
check-multi-juju Build finished.
Details
@babbageclunk babbageclunk deleted the babbageclunk:2.6-vsphere-clone-use-right-datastore branch Oct 10, 2019
jujubot added a commit that referenced this pull request Oct 11, 2019
#10721

## Merge to bring forward
- #10717 Fix permission error for k8s unit peer relations
- #10705 Fix block device matching priority
- #10714 vsphere: Specify the target datastore when cloning the template
- #10704 vsphere: Change extend disk polling to investigate bug 1847245
- #10692 Fix model-defaults functional test
- #10693 acceptance tests: Tweak assess runner to run under python 3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.