Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1864900 ACME v2 autocert support #11299

Merged
merged 1 commit into from Mar 14, 2020
Merged

Fix 1864900 ACME v2 autocert support #11299

merged 1 commit into from Mar 14, 2020

Conversation

@hpidcock
Copy link
Member

hpidcock commented Mar 9, 2020

Description of change

Updated golang.org/x/crypto package to support
ACME v2 autocert protocol.

QA steps

NOTE: need access to a domain

  • juju boostrap cloud --config autocert-dns-name=controller.my.domain
  • Update the controller.my.domain RR on the NS for my.domain to point to the controller IP.
  • Wait for the apiserver worker to get the letsencypt cert.
  • You should be able to browse https://controller.my.domain in your browser with a valid cert.

Documentation changes

N/A

Bug reference

https://bugs.launchpad.net/juju/+bug/1864900

@hpidcock

This comment has been minimized.

Copy link
Member Author

hpidcock commented Mar 10, 2020

!!build!!

@jameinel jameinel force-pushed the juju:2.7 branch from a17f8b6 to 9da5b59 Mar 10, 2020
@hpidcock hpidcock force-pushed the hpidcock:fix-1864900 branch from 33e0df3 to d7fe70f Mar 12, 2020
@hpidcock

This comment has been minimized.

Copy link
Member Author

hpidcock commented Mar 13, 2020

!!build!!

Updated golang.org/x/crypto package to support
ACME v2 autocert protocol.
@hpidcock hpidcock force-pushed the hpidcock:fix-1864900 branch from d7fe70f to e043f2f Mar 13, 2020
@hpidcock

This comment has been minimized.

Copy link
Member Author

hpidcock commented Mar 13, 2020

$$merge$$

2 similar comments
@hpidcock

This comment has been minimized.

Copy link
Member Author

hpidcock commented Mar 13, 2020

$$merge$$

@hpidcock

This comment has been minimized.

Copy link
Member Author

hpidcock commented Mar 14, 2020

$$merge$$

@jujubot jujubot merged commit bebbf9c into juju:2.7 Mar 14, 2020
3 of 5 checks passed
3 of 5 checks passed
Client Tests (ubuntu-latest) Client Tests (ubuntu-latest)
Details
Lint
Details
Schema
Details
check-multi-juju Build finished.
Details
merge-multi-juju Build started for merge commit.
Details
jujubot added a commit that referenced this pull request Mar 16, 2020
#11320

## Description of change

Merge 2.7 into deveop, with these commits:

#11299 ACME v2 autocert support
#11316 unit test for charm nil profile fix
#11301 recreate k8s exec client on failure

Also some drive by cleanup based on comments from last forward merge of 2.7 in #11314 

## QA steps

run unit tests
@manadart

This comment has been minimized.

Copy link
Member

manadart commented Mar 16, 2020

This appears to have broken the x390 build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.